search

githubtraining / ci-circle

Course repo for Learning Lab course "Continuous Integration with CircleCI". Template repo ➡
https://github.com/githubtraining/ci-circle-template
Creative Commons Attribution 4.0 International
3 stars 9 forks source link

Double comments in first issue #55

Closed brianamarie closed 5 years ago

brianamarie commented 5 years ago

I'm not sure what's going on, but for the 2nd time through the course, I'm getting double posts of comments. I think it might have to do with 2 statuses being reported, but I'm not sure how that would work.

@JasonEtco @JamesMGreene Could you help resolve this?

screen shot 2018-12-18 at 14 53 32
brianamarie commented 5 years ago

This didn't happen on my last round...so I'm going to close this....but I'll reopen if it happens again.

cc @beardofedu @a-a-ron @hollenberry in case you run across this during happy path.

hollenberry commented 5 years ago

@brianamarie reopening, as this is also happening on my end.

hectorsector commented 5 years ago

Circle sends multiple status events and Learning Lab is acting on them all. I think it’s a bug we should open in the Learning Lab repo. On our end, we can probably check what’s unique about each event and gate so we only act on one of the 3 events.

brianamarie commented 5 years ago

I opened an issue: https://github.com/github/learning-lab/issues/936

To write the gate, I'm not sure how to proceed. (What API information can we use as the gate?) Any takers to try and code this into the config? @a-a-ron @hollenberry @JasonEtco @ppremk @beardofedu

hectorsector commented 5 years ago

We can inspect the payload of the status events by subscribing a learner’s repo to a Smee channel, and then start the connection with Circle. You’ll see 3 status events (I believe one each for: pending, waiting, and success/fail).

hollenberry commented 5 years ago

^ @JasonEtco 's fix works as of my most recent test. 🎉