search

githubtraining / ci-circle

Course repo for Learning Lab course "Continuous Integration with CircleCI". Template repo ➡
https://github.com/githubtraining/ci-circle-template
Creative Commons Attribution 4.0 International
3 stars 9 forks source link

Create Bot Responses #6

Closed carolynshin closed 5 years ago

carolynshin commented 5 years ago

Task

Revisions based on course changes will/may happen through 12/10

carolynshin commented 5 years ago

Moving this issue to in progress 😄

a-a-ron commented 5 years ago

@carolynshin thank you for creating these issues for better organization. I've been going through the responses but quickly got hung up on knowing what "content" needs to be written for most of the steps. The config is awesome, @hectorsector but i'm missing the "meat" with knowing what exactly to include in the responses. For example, https://github.com/githubtraining/ci/blob/master/config.yml#L40-L43

image I need to write a response with instructions on asking the learner to open a PR. Are we asking them to open a PR from an existing branch brought over from the template repo? If so, which one? What is this PR doing?

The next step is asking them to commit a fix. Similar questions arise here as well like, What's the fix? What do I need to instruct the learner to do?

Do we have an outline in addition to the config that gives me more context on what the visionary of the course was thinking when building out the steps?

I thought this "outline" from the apps course was very helpful in letting me know what to do with each step https://github.com/githubtraining/introduction-to-github-apps/issues/68. Something similar to this would be very helpful.

hectorsector commented 5 years ago

Here's the outline and the pseudoconfig.

carolynshin commented 5 years ago

Changing dates to 12/10 - 12/11! @a-a-ron are you ok with that?

carolynshin commented 5 years ago

I see the PR above is merged. @a-a-ron is this good to close?