search

githubtraining / ci-circle

Course repo for Learning Lab course "Continuous Integration with CircleCI". Template repo ➡
https://github.com/githubtraining/ci-circle-template
Creative Commons Attribution 4.0 International
3 stars 9 forks source link

Enable branch protection at beginning, and remove before first merge #63

Closed brianamarie closed 5 years ago

brianamarie commented 5 years ago

This pull request fixes #61 by enabling branch protection before the first merge, and enabling it right as we ask them to merge.

cc @hollenberry for 👀

@hollenberry if this looks good to you, go ahead and 🚢 👍

a-a-ron commented 5 years ago

This looks good @brianamarie. I'm going to merge this in 😄

hollenberry commented 5 years ago

Confirmed: This works post merge.