search

githubtraining / ci-circle

Course repo for Learning Lab course "Continuous Integration with CircleCI". Template repo ➡
https://github.com/githubtraining/ci-circle-template
Creative Commons Attribution 4.0 International
3 stars 9 forks source link

Instructions for protected branches should ask user to turn OFF update from master #89

Closed brianamarie closed 5 years ago

brianamarie commented 5 years ago

If we have users update their branch from master, that extra commit triggers the next step of the course before we mean it to. If they do this, they'll still be blocked from merging until they have a passing build, but it's still not ideal. We should specify in the instructions to _uncheck Require branches to be up to date before merging.