Corrected Azure web app version

githubtraining / continuous-delivery-azure

Course repository for the Learning Lab course GitHub Actions: Continuous Delivery with Azure

https://lab.github.com/githubtraining/github-actions:-continuous-delivery-with-azure/

Creative Commons Attribution 4.0 International

0 stars 2 forks source link

Corrected Azure web app version #19

Closed davenowell closed 4 years ago

davenowell commented 4 years ago

This PR refers to issue #18

github-learning-lab[bot] commented 4 years ago

Your draft course version was created!

You can edit it using the Course Builder UI!

brianamarie commented 4 years ago

~~✋ I will test this now!~~ I take this back - I will not test this now. Spinning up the Azure environment would take me a long time because I haven't done it in a long time. Maybe someone who is closer to the Azure space or to this course would be better to test, like @lmkeston or @mattdavis0351? Or anyone else who has the bandwidth to get it going 😊

brianamarie commented 4 years ago

Edited my comment - I am going to take my ring out of the hat for reviewing at this time. Sorry for the false alarm!

hectorsector commented 4 years ago

I attached the source issue #18 to the project board and into the needs review column. This should help additional folks see that it needs review.

lmkeston commented 4 years ago

~✋ I will test this now!~ I take this back - I will not test this now. Spinning up the Azure environment would take me a long time because I haven't done it in a long time. Maybe someone who is closer to the Azure space or to this course would be better to test, like @lmkeston or @mattdavis0351? Or anyone else who has the bandwidth to get it going 😊

I can run through this @brianamarie. I'll assign it to me on the board.

cc: @hectorsector @davenowell

github-learning-lab[bot] commented 4 years ago

This pull request will create a new major version of your course; changes to the title and other metadata will only apply to the course once the pull request is merged!

hectorsector commented 4 years ago

@lmkeston the newest deployment should be functional and you should now be able to test the course

davenowell commented 4 years ago

@hectorsector So, clicking view deployment after your change gives me a 404 page. What am I doing wrong?

hectorsector commented 4 years ago

I have 3 potential solutions:

Make sure you're signed into Learning Lab
Make sure your staff bar is enabled on Learning Lab
Make sure you're clicking on the most recent Deployment button

If all those 3 are confirmed maybe it's something to do with permissions and we have to look deeper.

lmkeston commented 4 years ago

@lmkeston the newest deployment should be functional and you should now be able to test the course

@hectorsector, it's letting me test now - thanks!

mickeygousset commented 4 years ago

Step 7 now fails for a different reason. It can't find the action.

mickeygousset commented 4 years ago

There is no V2 version of Azure/webapps-container-deploy. The latest is v1.0.1

mickeygousset commented 4 years ago

ooohhhh, we have to use a completely different action it seems: ##[warning]Input 'app-name' has been deprecated with message: This action is ARCHIVED and will not receive any updates, update your workflows to use azure/webapps-deploy@v2

Going to try that.

mickeygousset commented 4 years ago

Ok, that is the problem. In the deploy_staging.yml file, we have to change the azure/web-container-deploy@v2 to azure/webapps-deploy@v2