search

githubtraining / continuous-delivery-azure

Course repository for the Learning Lab course GitHub Actions: Continuous Delivery with Azure
https://lab.github.com/githubtraining/github-actions:-continuous-delivery-with-azure/
Creative Commons Attribution 4.0 International
0 stars 2 forks source link

Step 6: Blocked if approving before label #4

Closed lmkeston closed 4 years ago

lmkeston commented 4 years ago

Describe the bug On step 6, if you approve before applying the label, it's not recoverable.

To Reproduce Step 6 Instructions: image

Steps to reproduce the behavior:

  1. On step 6, approve changes without applying label.
  2. The bot responds appropriately, telling you the expected action was applying the label.
  3. Apply the label
  4. Approve again

I couldn't get past this step after completing the approve task before the label...

hectorsector commented 4 years ago

@lmkeston I wasn't able to reproduce it. Here's my attempt. Maybe the PR just didn't refresh in time for you? If you can reproduce it, could you leave your repo up and send me a link? That'll allow me to dig into the logs and see if I find any errors.

lmkeston commented 4 years ago

@hectorsector I will try and reproduce it again later today. I bet it was a timing issue, if it worked for you.

lmkeston commented 4 years ago

@hectorsector this time it worked perfectly so I think it was a timing thing. I'll go ahead and close this.