search

githubtraining / continuous-delivery-azure

Course repository for the Learning Lab course GitHub Actions: Continuous Delivery with Azure
https://lab.github.com/githubtraining/github-actions:-continuous-delivery-with-azure/
Creative Commons Attribution 4.0 International
0 stars 2 forks source link

Incorrect instructions in GitHub Actions: Continuous Delivery with Azure lab #40

Open andrekolodochka opened 3 years ago

andrekolodochka commented 3 years ago

Describe the bug Incorrect instructions in GitHub Actions: Continuous Delivery with Azure lab

To Reproduce The Step 8 in the lab requests to add the following lines to deploy-prod.yml:

env:
  AZURE_RESOURCE_GROUP: cd-with-actions
  AZURE_APP_PLAN: actions-ttt-deployment
  AZURE_LOCATION: '"Central US"'
  #################################################
  ### USER PROVIDED VALUES ARE REQUIRED BELOW   ###
  #################################################
  #################################################
  ### REPLACE USERNAME WITH GH USERNAME         ###
  AZURE_WEBAPP_NAME: andrekolodochka-ttt-app
  #################################################

(andrekolodochka-ttt-app above will be different for each user)

image

Doing so will result in errors in create image and store in Packages step: image

Expected behavior The correct lines to add are:

env:
  DOCKER_IMAGE_NAME: andrekolodochka-azure-ttt
  IMAGE_REGISTRY_URL: docker.pkg.github.com
  #################################################
  ### USER PROVIDED VALUES ARE REQUIRED BELOW   ###
  #################################################
  #################################################
  ### REPLACE USERNAME WITH GH USERNAME         ###
  AZURE_WEBAPP_NAME: andrekolodochka-ttt-app
  #################################################

(again, andrekolodochka above will be different per user)

This is actually how it is shown at a later Step 9 in the same PR in the lab: image

So if I copy and replace the whole workflow in Step 9 - it would work. But if I only copy-paste the jobs section - I'd get an error in create image and store in Packages step.

github-actions[bot] commented 3 years ago

Thanks for opening this issue!

What happens next?

One of GitHub's maintainers will triage this issue. You can help speed this up by giving us as much detail as possible in your report. If you're reporting a bug, please let us know if you can replicate it with consistency.

Want to help?

You may be able to address this issue yourself! Start by reading the contributing guide.