search

githubtraining / introduction-to-github-apps

Course repo for Learning Lab course "introduction-to-github-apps". Template repo :arrow_right:
https://github.com/githubtraining/introduction-to-github-apps-template
Creative Commons Attribution 4.0 International
2 stars 7 forks source link

Standardize periods #100

Closed brianamarie closed 5 years ago

brianamarie commented 5 years ago

"Go look for the next set of instructions in your first pull request." - remove period for consistency cc @hollenberry

brianamarie commented 5 years ago

WIP Below the surface - 

1. Return to your unique smee.io link, accessible via your settings if you closed it
1. Identify the webhook event that was triggered. Remember, you edited the pull request title
1. Post the event exactly as it's written in smee.io in a comment on this pull request
1. Refresh if you don't see a response from me before merging

Since there are multiple sentences in at least one item, they should all have periods. Or, that step should be made only one sentence.

EDIT - while there, the instructions aren't super clear - maybe replace with: 

1. Return to your unique smee.io link
    - Closed your window? Scroll up to your comment above - it's the same URL
1. Find the names of the triggered webhook events
1. Comment in this pull request with the name of webhook event, exactly as it's written in smee.io
1. Refresh if you don't see a response from me before merging