Update - Githubissues

hollenberry commented 6 years ago

It has been a long day. Can provide more context tomorrow.

We dramatically overhauled this course based on feedback. See https://github.com/githubtraining/introduction-to-github-apps/pull/12 for context.
Did you know that installation events don't come with a payload? Now you do! Required some crisis management.
To replace the first installation event, we re-introduced a flow that doesn't feel perfect by asking the user to assign themselves. Open to another suggestion.
The second installation event is still possible because Bex allowed us to customize the request info app for learning lab courses. Now the app is supposed to introduce itself when it successfully installs, so we're listening for a comment instead. The attempt was here, but it isn't working yet. We can't progress until Bex wakes up.
Responses and flow are still reviewable. Very close to happy path completion once the above bullet is resolved.

brianamarie commented 6 years ago

I'm going through the happy path now before trying the unhappy path that is due by the EOD, and having to take a break for meetings. I'll come back but in the meantime I've been opening issues for things that need tweaked.

hollenberry commented 5 years ago

closing in favor of #70

githubtraining / introduction-to-github-apps

Update #17