search

githubtraining / introduction-to-github-apps

Course repo for Learning Lab course "introduction-to-github-apps". Template repo :arrow_right:
https://github.com/githubtraining/introduction-to-github-apps-template
Creative Commons Attribution 4.0 International
2 stars 7 forks source link

Wording fix in first issue #26

Closed brianamarie closed 6 years ago

brianamarie commented 6 years ago

Edit the first PR body so the sentence is clearer: The user should just assign themselves. Also, remove or edit the note after step 1 so it's not visually confusing.

"Try it out! After you install the WIP app, try and assign myself or the WIP app to this PR. If you can't, assign yourself so I know you're ready to get started."

hollenberry commented 6 years ago

This is mentioned in https://github.com/githubtraining/introduction-to-github-apps/issues/17#issue-368511976.

Having slept on it, let's change the flow so that the first prompt is to install the app, and then close the issue to mark complete. Feels "clicky", but we're open to other suggestions. This removes the arbitrary feeling of a random self-assignment, and breaks up the tasks with clarity.

brianamarie commented 6 years ago

@hollenberry Okay. I've updated the title, labels, and OP.

brianamarie commented 6 years ago

@hollenberry Actually the first thing that is opened is a pull request, and if the user closes the pull request, they won't be able to continue the course as written. I'm going to update the OP again with what I think is the lowest friction path forward, though still don't know if it's ideal.