search

githubtraining / introduction-to-github-apps

Course repo for Learning Lab course "introduction-to-github-apps". Template repo :arrow_right:
https://github.com/githubtraining/introduction-to-github-apps-template
Creative Commons Attribution 4.0 International
2 stars 7 forks source link

Trigger failing after removing WIP #29

Closed brianamarie closed 6 years ago

brianamarie commented 6 years ago

After removing WIP, I merged, but the bot never commented or opened another issue.

hollenberry commented 6 years ago

Hmm. This is interesting behavior. Last night it worked successfully and auto-merged with a comment to follow-up. Can you try this again to confirm?

brianamarie commented 6 years ago

@hollenberry It was what happened. I'm going to take a peek into the config. https://github.com/brianamarie/introduction-to-github-apps/pull/1

screen shot 2018-10-10 at 17 17 13
brianamarie commented 6 years ago

I'm not sure if this happened because of the error message, or because I was just too fast in clicking. Either way, I don't think we can guarantee that a user won't run into this as the course is.

What if we added a step: We still test for the removal of "WIP", but then instead of merging, we comment saying "good job" and instruct the user to merge, and then use the user's merge as the trigger for the next action/event?

brianamarie commented 6 years ago

I'll open a PR for the above solution and let @a-a-ron and @hollenberry decide if that's an OK way to take the course.