We add things in PRs but don't address the content

githubtraining / introduction-to-github-apps

Course repo for Learning Lab course "introduction-to-github-apps". Template repo :arrow_right:

https://github.com/githubtraining/introduction-to-github-apps-template

Creative Commons Attribution 4.0 International

2 stars 7 forks source link

We add things in PRs but don't address the content #30

Closed brianamarie closed 5 years ago

brianamarie commented 6 years ago

Adding dummy PRs doesn't seem to jive with the rest of our courses that create something of value to the user after the fact. I think that's the quality we should aim for.

At the very least, I think we need to address what's going on to the user when they're merging a PR without actually looking at what the content of that PR is.

hollenberry commented 6 years ago

Hmm.

Since apps are the great takeaway of the course, and we want the user to install more of them as they start on any project, maybe the project for this course can be to end with a good README.md template.

This allows the user to continue to build out the repo with a strong start, and in whichever way they choose, with some app knowledge in hand.

@a-a-ron what do you think?

hectorsector commented 6 years ago

@hollenberry I think we can address this by centering the template repo around a real project. The PRs would then not feel forced and like part of the natural workflow, which also follows the pattern we've modeled in our other courses. An idea, would be this list of browser-based games by our very own @leereilly. Another option is to go crazy hacking MS DOS (although can't deploy it to GitHub Pages).

By centering around a real project, we can just identify a single task that needs doing, create a WIP PR for that and, voila, non forced PR!

brianamarie commented 6 years ago

@hectorsector I love the idea of using a fork or version of https://github.com/leereilly/games#browser-based. The activities could be:

WIP: Adding a game to the list, but at first it's not linked, and then we later have another branch merge in that will complete it so the user can remove WIP
Request Info: we can request that users change their config file to include something like "We would appreciate it if you could provide us with more information about this issue or pull request. Are you trying to edit a game already on the list, or add one?"

I will work on this next 👍

@hollenberry @a-a-ron I won't change the config or template repo immediately but I will push an alternate up so that we can move quickly if this direction is OK.

brianamarie commented 5 years ago

I propose we use this repository: https://github.com/githubtraining/games

PR incoming.