search

githubtraining / introduction-to-github-apps

Course repo for Learning Lab course "introduction-to-github-apps". Template repo :arrow_right:
https://github.com/githubtraining/introduction-to-github-apps-template
Creative Commons Attribution 4.0 International
2 stars 7 forks source link

Bug #71

Closed brianamarie closed 5 years ago

brianamarie commented 5 years ago

There's a logic bug here: https://github.com/githubtraining/introduction-to-github-apps/blob/36f26f39ac1e47a0c1f126821fe936b280d58245/config.yml#L86-L93

brianamarie commented 5 years ago

Currently, it looks like there are two gates that are disabled. If the body is empty, we want to give one response, and if the body isn't empty, we want to give another response.

I'm guessing this is failing because both of these end with else statements, and without any other action, so things are getting hung up and not moving on.

The only difference in what would be posted is a paragraph in the response. What if, if the body isn't empty, we post an additional comment with the extra information? This also would reduce duplicated text in multiple files.