search

githubtraining / introduction-to-github

Course repo for Learning Lab course "Introduction to GitHub". Template repo ➡️
https://github.com/githubtraining/caption-this-template
Creative Commons Attribution 4.0 International
77 stars 53 forks source link

French translation 🇫🇷 #44

Closed hectorsector closed 4 years ago

hectorsector commented 4 years ago

This PR recreates the work in https://github.com/githubtraining/introduction-to-github/pull/43 so that we can deploy from this branch and test.

github-learning-lab[bot] commented 4 years ago

Your draft course version was created!


You can edit it using the Course Builder UI!

github-learning-lab[bot] commented 4 years ago
This pull request will create a new major version of your course; changes to the title and other metadata will only apply to the course once the pull request is merged!
brianamarie commented 4 years ago

Friendly bump on this @helaili - have you had a chance to look over @SophieLegrand's review?

helaili commented 4 years ago

I did @brianamarie but as mentioned on Slack I need push access to be able to commit it back.

brianamarie commented 4 years ago

I did @brianamarie but as mentioned on Slack I need push access to be able to commit it back.

Ah - I'm so sorry I missed that before. I've opened a PR with entitlements that should unblock you once it's merged. 😄

helaili commented 4 years ago

@brianamarie changes have (finally 😊 ) been pushed.

brianamarie commented 4 years ago

This is so awesome!!! Thank you so much @helaili and @SophieLegrand!

I have tested this out (English and French) for the first few steps, and everything looks as expected. 🎉 I am on "comms duty" for the team this week, so I'm going to go ahead and merge, and I'll also keep an eye out on the community forum and Halp in case there are any unexpected issues.