search

githubtraining / introduction-to-github

Course repo for Learning Lab course "Introduction to GitHub". Template repo ➡️
https://github.com/githubtraining/caption-this-template
Creative Commons Attribution 4.0 International
77 stars 54 forks source link

GitHub Slideshow pages site does not have control arrows #73 #58

Closed ernest-phillips closed 3 years ago

ernest-phillips commented 4 years ago

Describe the bug

Users from the community forum have reported this experience. After deploying Pages site, there are no controls for progressing through the slideshow.

Screen Shot 2020-10-26 at 11 38 39 AM

Link to my Page https://ernest-phillips.github.io/github-slideshow/#/

Based on the developer tools, I expect to see a right arrow control on the bottom right of the screen. Changing zoom does not help button to appear.

To Reproduce Steps to reproduce the behavior:

  1. Start the Introduction to GitHub course
  2. Complete steps 1-3
  3. Go to your deployed GitHub Pages site
  4. Try to click through the slideshow

This was tested in: Google Chrome browser 86.0.4240.111 (mobile also) Firefox 81.0.2 Safari 14.0

jedpepper commented 4 years ago

We all have it working now 👍

Calorion commented 3 years ago

It is not working for me. I kept tapping the right arrow on my keyboard with no effect, and there is no visible arrow on the screen. https://calorion.github.io/github-slideshow/

Screen Shot 2021-02-26 at 11 57 16 AM
ernest-phillips commented 3 years ago

It is not working for me. I kept tapping the right arrow on my keyboard with no effect, and there is no visible arrow on the screen. https://calorion.github.io/github-slideshow/

Screen Shot 2021-02-26 at 11 57 16 AM

Make sure to create a new markdown file in the _posts folder. There should be a new issue in your repository that explains what to do. Right now you only have one post and that is the represents the initial slide in the deck. So, the arrow will not show. Once the new post is created, you should be able to load your Pages site with the new slide.

Calorion commented 3 years ago

Okay, sure, but for people just doing this, they don’t know that the reason that they don’t see an arrow is that they are going to be told to create another slide in the future. So something to that effect in the instructions would be good, just to reduce confusion.