githubtraining / looking-glass-action

provides feedback to learners based on the outcome of their validation lab grader workflow
MIT License
35 stars 10 forks source link

Improper reference to 'payload' variable #25

Closed mattdavis0351 closed 3 years ago

mattdavis0351 commented 3 years ago

https://github.com/githubtraining/looking-glass-action/blob/7418f584cf297949cee195cb3998840abff8dc8c/lib/lookingGlass.js#L69

There is no payload variable when using actions as the display_type and as a result this line throws an extra error when an incorrect action is taken. Screenshot below.

image

fix:

Remove this line and set forceWorkflowToFail with a message that does not reference a payload. There should be no reference to an issue if we are using this display_type

isBreaking: NO!

In its current state this is NOT a breaking bug, it is more of an annoyance and could be slightly confusing to the learner in the long run.

This will be addressed in the next Looking Glass update.

mattdavis0351 commented 3 years ago

this was close in #28