search

githubtraining / looking-glass-action

provides feedback to learners based on the outcome of their validation lab grader workflow
MIT License
35 stars 10 forks source link

Send customErrors to debugger properly #29

Closed mattdavis0351 closed 3 years ago

mattdavis0351 commented 3 years ago

This pull addresses unexpected feedback being displayed to the learner when they perform an action and something breaks that isn't related to their action. Example, improper workflow syntax which breaks at the Actions level, not the grading level.

This addresses issues found with valueErrors here and schemaErrors here

This commit also closes these issues. To test change grading.yml to point to githubtraining/looking-glass-action@fix-value-error-handling' and make sureACTIONS_STEP_DEBUGGER` is set as a repo secret to see the error obscured from the learner but displayed for the developer/author

mattdavis0351 commented 3 years ago

@hectorsector, I ran a test for this here in mirror to your attempt here

could you please do some manual testing and give me a thumbs up to merge if you don't break anything, thanks!