search

githubtraining / release-workflow

Course repo for Learning Lab course "Create a release based workflow".
https://lab.github.com/githubtraining/create-a-release-based-workflow
Creative Commons Attribution 4.0 International
1 stars 6 forks source link

Unhappy Path Test #106

Closed beardofedu closed 5 years ago

beardofedu commented 5 years ago

@hectorsector

Step 1: Create a release

Step 2: Organizing a release

Step 5: Adding a feature

Step 8: Approving other pull requests

Step 9: Adding a change log

hectorsector commented 5 years ago

Thanks so much for testing, @beardofedu!

Tried to use .8 as the release name, GitHub told me that wouldn't work and how to fix it 🚧 Selected bug-fix as the target branch and LL moved to the next step

As the idea is that they create a release, I'm OK with not checking the release source 👍

🚧 Used the Bug triage template, LL moved to the next step 🚧 Didn't have a "In Progress" column, added it to "Needs triage", LL moved to the next step

Not a big deal here, the idea is that they learn how to create a project and drop a card. If they don't choose automated Kanban, it just means they have different column titles.

🚧 Didn't fix the link correctly, LL was ok with it and moved to the next step

I think this is OK too

Image is currently broken (in the drop down)

Fixed in https://github.com/githubtraining/release-workflow/pull/107

Added a comment (not an approval) and LL didn't respond

I think this is OK since we're asking for an Approval.

For some reason the Pull Request is closed 🚧 The course seems to be frozen

@beardofedu I tried to see this in your repo but I can't find it. Is it private by chance or deleted?

hectorsector commented 5 years ago

🚧 The course seems to be frozen

Now that I think about it, I think I know what caused this. Creating a PR against the wrong branch in step 5, caused the PR numbers to be +1, and there are some cases where we refer to the PR by number of logic. Let me see if I can improve this by checking against the branch.

hectorsector commented 5 years ago

🚧 The course seems to be frozen

Fixed in #108. I think this should take care of any remaining issues. Thanks again for testing, @beardofedu.