Edits and fixes for GHES QA - Githubissues

githubtraining / release-workflow

Course repo for Learning Lab course "Create a release based workflow".

https://lab.github.com/githubtraining/create-a-release-based-workflow

Creative Commons Attribution 4.0 International

1 stars 6 forks source link

Edits and fixes for GHES QA #115

Closed brianamarie closed 5 years ago

brianamarie commented 5 years ago

This pull request addresses:

[x] Course description (README.md), correct "GitHub Flow" to "GitHub flow"
[x] Check bullet points in README.md are sentence cased
[x] "Welcome"; correct the casing of "GitHub flow"
[x] "Great work!", check out your "project"; incorrect URL
[x] "Step 4", first step has incorrect Pages URL
[x] "Step 4", typo in step 4, "thre"
[x] "Release branches and master", typo "###step 6"
[x] "Congratultaions", typo "check out our outher courses?"

cc @githubtraining/learning-engineering @githubtraining/trainers

todo[bot] commented 5 years ago

FIX URL `https://{{ username }}.github.io/release-based-workflow`

https://github.com/githubtraining/release-workflow/blob/14d1bf78c2b5a9c3c6fb12ce9bcb1d1fb0e24c58/responses/03.1_update-readme.md#L32-L37

This comment was generated by todo based on a `TODO` comment in 14d1bf78c2b5a9c3c6fb12ce9bcb1d1fb0e24c58 in #115. cc @githubtraining.

todo[bot] commented 5 years ago

FIX URL `https://{{ username }}.github.io/release-based-workflow`

https://github.com/githubtraining/release-workflow/blob/d649e12f225cdadc0f0b76ca124e16e0ba4668b2/responses/03.1_update-readme.md#L32-L37

This comment was generated by todo based on a `TODO` comment in d649e12f225cdadc0f0b76ca124e16e0ba4668b2 in #115. cc @githubtraining.

todo[bot] commented 5 years ago

FIX URL `https://{{ username }}.github.io/release-based-workflow`

https://github.com/githubtraining/release-workflow/blob/c44826fa728c60f45b143892a866ab8a888ee92d/responses/03.1_update-readme.md#L32-L37

This comment was generated by todo based on a `TODO` comment in c44826fa728c60f45b143892a866ab8a888ee92d in #115. cc @githubtraining.

todo[bot] commented 5 years ago

FIX URL `https://{{ username }}.github.io/release-based-workflow`

https://github.com/githubtraining/release-workflow/blob/71cd7cc02e1a7c940aac407b98a757dacf9e721a/responses/03.1_update-readme.md#L32-L37

This comment was generated by todo based on a `TODO` comment in 71cd7cc02e1a7c940aac407b98a757dacf9e721a in #115. cc @githubtraining.

todo[bot] commented 5 years ago

FIX URL `https://{{ username }}.github.io/release-based-workflow`

https://github.com/githubtraining/release-workflow/blob/2f11cf6e7bbd3e6f795821c4d0b8c4795b23a400/responses/03.1_update-readme.md#L32-L37

This comment was generated by todo based on a `TODO` comment in 2f11cf6e7bbd3e6f795821c4d0b8c4795b23a400 in #115. cc @githubtraining.

todo[bot] commented 5 years ago

FIX URL `https://{{ username }}.github.io/release-based-workflow`

https://github.com/githubtraining/release-workflow/blob/55215f9f8f0dd21876fed12ec21f9e35d10c3363/responses/03.1_update-readme.md#L32-L37

This comment was generated by todo based on a `TODO` comment in 55215f9f8f0dd21876fed12ec21f9e35d10c3363 in #115. cc @githubtraining.

brianamarie commented 5 years ago

This is ready for review! I'd like to 🚢 with 1 👍 but will consider merging without review to make sure this can be on ghe tomorrow. cc @githubtraining/learning-engineering @githubtraining/trainers for 👀

Edit: Wasn't expecting the draft to fail. Any ideas? 🤔

brianamarie commented 5 years ago

User submission of typos: https://halp.githubapp.com/inboxes/learning-lab/discussions/e5f333f8726f11e99ebb201cd067e400

Points out that an occurrence should be "Several changes might be included in release branches."

brianamarie commented 5 years ago

There is a blocker on this course, for some reason the step to create a PR backporting the hotfix to the release branch is not showing differences between those two branches.

      - type: createPullRequest
        title: Backport the hotfix
        body: 12.1_backport.md
        head: bug-fix
        base: release-v1.0

@hectorsector I'm running out of steam but I want to make sure this is on your radar as high priority to ship today.

brianamarie commented 5 years ago

I got the bug fixed, and tested on .com. Working 👍