search

githubtraining / release-workflow

Course repo for Learning Lab course "Create a release based workflow".
https://lab.github.com/githubtraining/create-a-release-based-workflow
Creative Commons Attribution 4.0 International
1 stars 6 forks source link

Consider dependency on "Release Drafter" #116

Closed brianamarie closed 5 years ago

brianamarie commented 5 years ago

This course depends on using the "Release Drafter" Probot app. This is fine for .com, but presents major issues for GHES usage.

I couldn't install this on GHE, and I suspect our customers won't be able to install it easily on their instances either.

I was able to create the PR and fake my way through the course, but this needs clarifying from an instructional perspective if we don't want all users to be stuck here. This also leads to instructions that don't make sense. Next steps are all based on creating new releases or editing releases that have been drafted by the app.

The concepts can be taught without the app, and even though it's cool, I suggest we remove it from the course and include it instead at the end in the "Congratulations" issue.

cc @githubtraining/learning-engineering @githubtraining/trainers and very especially @hectorsector

brianamarie commented 5 years ago

Closing out since github/learning-lab#1280 is done.