githubtraining / release-workflow

Course repo for Learning Lab course "Create a release based workflow".
https://lab.github.com/githubtraining/create-a-release-based-workflow
Creative Commons Attribution 4.0 International
1 stars 6 forks source link

Do we care about these? #129

Open amyschoen opened 4 years ago

amyschoen commented 4 years ago

Deleting the template and starting a discussion thread instead. I've been purposely taking the course a bit wrong and I found these issues. Curious if there's desire to check for these or not. I am seeing similar checks when I "make mistakes" :wink: in other parts of the course.

Screen Shot 2020-02-10 at 1 03 23 PM

/cc @crichID @brianamarie @hectorsector @JasonEtco

hectorsector commented 4 years ago

Thanks for the report, @amyschoen! My two cents here are that I'd like to block the learner as little as possible -- I've learned the hard way that forcing a learner to do something the right way blocks their progress more often than it helps. So: I try to only do this when it's necessary for the course to work properly (say, if the name of the Release is necessary for the bot to respond).

That being said, I still think we can tackle this by giving the learner feedback, something like:

You didn't name your release v1.0, like I expected, but we'll move on anyway.

amyschoen commented 4 years ago

I like that approach @hectorsector.