search

githubtraining / release-workflow

Course repo for Learning Lab course "Create a release based workflow".
https://lab.github.com/githubtraining/create-a-release-based-workflow
Creative Commons Attribution 4.0 International
1 stars 6 forks source link

Step 7 has a lot of extraneous lines in diff #130

Open amyschoen opened 4 years ago

amyschoen commented 4 years ago

Bug Report

Current behavior I'm seeing a lot of extra lines come up in the diff due to spacing differences in engine.js and game.js.

Screen Shot 2020-02-10 at 1 08 23 PM

Reproduction Steps to reproduce the behavior in the course:

  1. Take the course until you get to step 7.
  2. Take a look at the diff for the review.
  3. You'll see a lot of extra lines flagged in the diff due to a space or lack thereof.

Expected behavior I would expect the diff to show the new file (.github/release-drafter.yml) and only the changes to make the text green.

Possible solution Clean up the files on the green-colors branch.

Additional context GHES v2.19.6, LL v0.6.0

/cc @crichID @brianamarie @hectorsector @JasonEtco