Feedback: Going from PR 7 back to PR 6

githubtraining / release-workflow

Course repo for Learning Lab course "Create a release based workflow".

https://lab.github.com/githubtraining/create-a-release-based-workflow

Creative Commons Attribution 4.0 International

1 stars 6 forks source link

Feedback: Going from PR 7 back to PR 6 #91

Closed carolynshin closed 5 years ago

carolynshin commented 5 years ago

Origin: @jsfillman's feedback

I know it's minor, but it bugs me that we go from PR 7 back to PR 6 during the Automating releases portion. (Steps 9 & 10)

beardofedu commented 5 years ago

In a release branch based workflow, you would add your changes to the release branch (PR 7) and once all the changes for a specific release have been completed, the release branch would be merged into master (PR 6). Closing this issue , but pinging @hectorsector in case he wants to revisit this.