search

githubtraining / release-workflow

Course repo for Learning Lab course "Create a release based workflow".
https://lab.github.com/githubtraining/create-a-release-based-workflow
Creative Commons Attribution 4.0 International
1 stars 6 forks source link

WIP: Fix release drafter config step #96

Closed hectorsector closed 5 years ago

hectorsector commented 5 years ago

This PR will fix #36. It is still a WIP and for the time being using a modified repo history that I'm keeping in my test org.

Will merge after:

todo[bot] commented 5 years ago

change these instructions to indicate the need for a new PR with release drafter config

https://github.com/githubtraining/release-workflow/blob/ce7a55814045e973c9b33588144f6afb73c69681/config.yml#L191-L194

This comment was generated by todo based on a TODO comment in ce7a55814045e973c9b33588144f6afb73c69681 in #96. cc @githubtraining.
todo[bot] commented 5 years ago

request a review from the learner

https://github.com/githubtraining/release-workflow/blob/ce7a55814045e973c9b33588144f6afb73c69681/config.yml#L291-L294

This comment was generated by todo based on a TODO comment in ce7a55814045e973c9b33588144f6afb73c69681 in #96. cc @githubtraining.
todo[bot] commented 5 years ago

reduce possible extra PRs by allowing learner to change the base instead of closing PR

https://github.com/githubtraining/release-workflow/blob/6393480e18f07331274f039648da25e2f24929c6/config.yml#L111-L114

This comment was generated by todo based on a TODO comment in 6393480e18f07331274f039648da25e2f24929c6 in #96. cc @githubtraining.
todo[bot] commented 5 years ago

remove addition of release drafter config from `green-colors` PR, this is added at a later point

https://github.com/githubtraining/release-workflow/blob/6393480e18f07331274f039648da25e2f24929c6/config.yml#L179-L182

This comment was generated by todo based on a TODO comment in 6393480e18f07331274f039648da25e2f24929c6 in #96. cc @githubtraining.
todo[bot] commented 5 years ago

check that this PR is against the relase branch

https://github.com/githubtraining/release-workflow/blob/6393480e18f07331274f039648da25e2f24929c6/config.yml#L219-L223

This comment was generated by todo based on a TODO comment in 6393480e18f07331274f039648da25e2f24929c6 in #96. cc @githubtraining.
hectorsector commented 5 years ago

Tested locally, shipping to test on staging.

todo[bot] commented 5 years ago

remove addition of release drafter config from `green-colors` PR, this is added at a later point

https://github.com/githubtraining/release-workflow/blob/e818790c2a1ac6a1b6d71ebfb7653cca28a23f2c/config.yml#L179-L182

This comment was generated by todo based on a TODO comment in e818790c2a1ac6a1b6d71ebfb7653cca28a23f2c in #96. cc @githubtraining.
todo[bot] commented 5 years ago

remove addition of release drafter config from `green-colors` PR, this is added at a later point

https://github.com/githubtraining/release-workflow/blob/c1cc5def7a2033857f86a516ef65c7653770c0f3/config.yml#L179-L182

This comment was generated by todo based on a TODO comment in c1cc5def7a2033857f86a516ef65c7653770c0f3 in #96. cc @githubtraining.
todo[bot] commented 5 years ago

remove addition of release drafter config from `green-colors` PR, this is added at a later point

https://github.com/githubtraining/release-workflow/blob/cb9a3814a6ff2a07dde2e1810e5e56b723613877/config.yml#L179-L182

This comment was generated by todo based on a TODO comment in cb9a3814a6ff2a07dde2e1810e5e56b723613877 in #96. cc @githubtraining.
todo[bot] commented 5 years ago

remove addition of release drafter config from `green-colors` PR, this is added at a later point

https://github.com/githubtraining/release-workflow/blob/528dd41b9d71086ec114d0595f72329f9c2b3b12/config.yml#L179-L182

This comment was generated by todo based on a TODO comment in 528dd41b9d71086ec114d0595f72329f9c2b3b12 in #96. cc @githubtraining.