search

githubtraining / release-workflow

Course repo for Learning Lab course "Create a release based workflow".
https://lab.github.com/githubtraining/create-a-release-based-workflow
Creative Commons Attribution 4.0 International
1 stars 6 forks source link

Move release drafter config to earlier step #97

Open hectorsector opened 5 years ago

hectorsector commented 5 years ago

This is just a suggestion, not sure if I'm on board with it.

It seems that Step: adding a feature, isn't really asking the learner to make a meaningful change:

https://github.com/githubtraining/release-workflow/blob/d1ba8ec06482a6a4e8364441c46c9b69a79f0425/config.yml#L94-L118

Since we need the learner to add the config for release drafter anyway, perhaps we can suggest that change instead of the current extra step:

https://github.com/githubtraining/release-workflow/blob/d1ba8ec06482a6a4e8364441c46c9b69a79f0425/config.yml#L261-L274