search

githubtraining / training-manual

Home of the words in the GitHub Training Manual and teaching scripts.
https://githubtraining.github.io/training-manual
Creative Commons Attribution 4.0 International
270 stars 274 forks source link

Update Japanese materials #355

Closed dzeyelid closed 2 years ago

dzeyelid commented 2 years ago

I updated Japanese docs along with current English docs. Please review them.

I also some changes to English docs to improve them.

ppremk commented 2 years ago

@dzeyelid 👋🏽 are you able to paste the local test run screen capture and results in here please. This will help us to keep audit that this PR when merge works as expected and does not break the manual in general. 🙇🏽

junkofujiwara commented 2 years ago

verified the translation.

ppremk commented 2 years ago

Translation verified by @junkofujiwara. Good to merge when all test have passed.

dzeyelid commented 2 years ago

@junkofujiwara Thank you for verifying! @ppremk I fixed all linter errors, including some that I did not change but were shown as errors by the linter. Please confirm it 🙏

dzeyelid commented 2 years ago

@parkerbxyz Thanks for your review! I applied your feedback. Please confirm it. 🙏