githubtraining / training-manual

Home of the words in the GitHub Training Manual and teaching scripts.
https://githubtraining.github.io/training-manual
Creative Commons Attribution 4.0 International
267 stars 266 forks source link

Misc fixes to the training scripts #400

Open jessehouwing opened 1 year ago

jessehouwing commented 1 year ago
amyschoen commented 1 year ago

@jessehouwing, I merged my fix for #394 into this branch now that @parkerbxyz got me approved. I see that #390 looks like it fixes upgrading projects to v2. I hadn't considered the impact of making projects private on .com. We've been teaching on GHES historically, so Pages still work. I also like the idea of adding in Advanced Security as a part of the class. There are a lot of possibilities there.

jessehouwing commented 1 year ago

I hadn't considered the impact of making projects private on .com. We've been teaching on GHES historically, so Pages still work. I also like the idea of adding in Advanced Security as a part of the class. There are a lot of possibilities there.

@amyschoen We're teaching mostly through the GitHub Professional Services Partner Program and use the GitHub provided ps-developers-sandbox org to teach this class.

There is an admin class and a ghas class as well that already explains advanced security, but it's easier if the users are in a fully enabled public repo where a demo or answer to a question may lead to demoing these advanced features.

jessehouwing commented 1 year ago

Now that there is a gh cli extension to create and setup projects, it's probably a lot easier to use and maintain that. Which is true for many other elements of this class. It would do away with many a hairy API call and is probably more long-term compatible.