githubtraining / using-github-actions-for-ci

Course repository for "GitHub Actions: Continuous Integration"
https://lab.github.com/githubtraining/github-actions:-continuous-integration
Creative Commons Attribution 4.0 International
3 stars 16 forks source link

Bug: Test results in first step #11

Closed brianamarie closed 4 years ago

brianamarie commented 4 years ago

In the first step, I am not sure what to expect from the tests; but, I see that the CI is failing or cancelled and I'm not sure how to proceed.

Screen Shot 2019-09-27 at 11 19 44
hectorsector commented 4 years ago

Hm... this should've responded when the check_suite completed, but I guess there's no response if the check_suite is cancelled (for whatever reason, I'm guessing outside of our control in this case). Thanks for this issue, the solution here is to add some troubleshooting on a general check_suite event.

https://github.com/githubtraining/set-up-continuous-integration-with-github-actions/blob/e60ad18f0c2125d649d96ae981d39836de15f043/config.yml#L68-L77

ntaranov commented 4 years ago

I too had impression that the bug might be caused by the workflow runner canceling 2 tests of 3 after first of them fails, so I updated my workflow template to only contain 1 Node.js version. The result is the same. The 'gate' check itself is likely broken.

image

lijenn commented 4 years ago

Crossref #42 & from the community thread:

Hi All, this could be a temporary solution or help lead with next steps to resolving this issue:

Try removing the period between node.js in the yml file name as shown here in Step 1 in part 3, before you commit the workflow to a new branch. image Rename it to just: nodejs.yml

I think the period confused the file type and the learning bot. Steps 2 & 3 showed up for me after this change.

Doesn't resolve why some checks were straight up cancelled though, if that ends up being another issue further down the course of the training.

mattdavis0351 commented 4 years ago

Problem was solved and merged into master! It was a combination of changing the course config as well as other changes to the starter workflow. #43 and #41 combined have solved the issue.