Closed rkzm closed 4 years ago
Current behavior
Discovered a bug in the Workflow file nodejs.yaml code that has me wondering how the virtual environments are set up.
nodejs.yaml
The whole course works fine but observant learners will ask whats going on:
👀 at the line
os: [ubuntu-lastest, windows-2016]
should be -latest
-latest
name: Node CI on: [push] jobs: build: runs-on: ubuntu-latest strategy: matrix: os: [ubuntu-lastest, windows-2016] node-version: [8.x, 10.x] steps: - uses: actions/checkout@v1 - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v1 with: node-version: ${{ matrix.node-version }} - name: npm install, build, and test run: | npm ci npm run build --if-present npm test env: CI: true
Will update these 👇
Reproduction Steps to reproduce the behavior in the course:
Expected behavior A clear and concise description of what you expected to happen.
Possible solution If you have suggestions, we'd love to hear them. If not, that's ok too.
Additional context Add any other context about the problem here. If applicable, add screenshots to help explain.
fixed by #23
Bug Report
Current behavior
Discovered a bug in the Workflow file
nodejs.yaml
code that has me wondering how the virtual environments are set up.The whole course works fine but observant learners will ask whats going on:
👀 at the line
should be
-latest
Will update these 👇
Reproduction Steps to reproduce the behavior in the course:
Expected behavior A clear and concise description of what you expected to happen.
Possible solution If you have suggestions, we'd love to hear them. If not, that's ok too.
Additional context Add any other context about the problem here. If applicable, add screenshots to help explain.