githubtraining / using-github-actions-for-ci

Course repository for "GitHub Actions: Continuous Integration"
https://lab.github.com/githubtraining/github-actions:-continuous-integration
Creative Commons Attribution 4.0 International
3 stars 16 forks source link

Typo in the Workflow file [OS matrix field] but still works #22

Closed rkzm closed 4 years ago

rkzm commented 4 years ago

Bug Report

Current behavior

Discovered a bug in the Workflow file nodejs.yaml code that has me wondering how the virtual environments are set up.

The whole course works fine but observant learners will ask whats going on:

👀 at the line

os: [ubuntu-lastest, windows-2016]

should be -latest

name: Node CI

on: [push]

jobs:
  build:

    runs-on: ubuntu-latest

    strategy:
      matrix:
        os: [ubuntu-lastest, windows-2016]
        node-version: [8.x, 10.x]

    steps:
    - uses: actions/checkout@v1
    - name: Use Node.js ${{ matrix.node-version }}
      uses: actions/setup-node@v1
      with:
        node-version: ${{ matrix.node-version }}
    - name: npm install, build, and test
      run: |
        npm ci
        npm run build --if-present
        npm test
      env:
        CI: true

Screen Shot 2019-11-07 at 15 04 41

Will update these 👇

Reproduction Steps to reproduce the behavior in the course:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Possible solution If you have suggestions, we'd love to hear them. If not, that's ok too.

Additional context Add any other context about the problem here. If applicable, add screenshots to help explain.

rkzm commented 4 years ago

fixed by #23