search

githubtraining / using-github-actions-for-ci

Course repository for "GitHub Actions: Continuous Integration"
https://lab.github.com/githubtraining/github-actions:-continuous-integration
Creative Commons Attribution 4.0 International
3 stars 16 forks source link

Fix some responses that are causing failures in the custom workflow course #24

Closed rkzm closed 4 years ago

rkzm commented 4 years ago

What does this PR do?

Fixes some issues discovered in the responses while running through the course.

Where should the reviewer start?

🔔 The commit 👉 924ec5a9953bde02dec9cf3595ab1a48ab5c3b1d makes the initial response follow the flow of the course

Screen Shot 2019-11-09 at 20 18 44

🔔 The commit 👉 2ee6120a270846699761fdeebabe6530438d11a5 fixes

1- the deletion of the checkout action

Screen Shot 2019-11-09 at 20 44 44

Build fails as follows

Screen Shot 2019-11-09 at 20 50 07

2- ensures that the upload-action is added after the command npm build If not then the build fails because the main.js artifact is not uploaded to Artifact Storage.

Screen Shot 2019-11-09 at 20 52 11

🔔 the commit a9b3645dffd77746050ca3922a797b407130d14a makes text consistent with the course flow

Screen Shot 2019-11-09 at 22 48 56

What testing has been done?

None so far on this branch. I can not get the branch to deploy anywhere.

Any background context you want to provide?

NA

What documentation has been created/updated?

This PR

crichID commented 4 years ago

@rkzm thank you for making these changes! It looks like there is an error importing the course from this branch so let me take a look at that really quick before you merge!