consider not using `master` for setup-node action

githubtraining / using-github-actions-for-ci

Course repository for "GitHub Actions: Continuous Integration"

https://lab.github.com/githubtraining/github-actions:-continuous-integration

Creative Commons Attribution 4.0 International

3 stars 16 forks source link

consider not using `master` for setup-node action #25

Closed rkzm closed 4 years ago

rkzm commented 4 years ago

Bug Report

Current behavior According to best practice for CI we recommend to use explicit versions of actions. major versions. For setup-action we are using master. This is not best practice unless it is done to educate.

Reproduction See nodejs.yml workflow file

Expected behavior Remove reference to master and call a version instead https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepsuses

mattdavis0351 commented 4 years ago

This looks to have been addressed when the starter workflow was updated. I'm closing this issue as a result.