githubtraining / using-github-actions-for-ci

Course repository for "GitHub Actions: Continuous Integration"
https://lab.github.com/githubtraining/github-actions:-continuous-integration
Creative Commons Attribution 4.0 International
3 stars 16 forks source link

Use job outputs in place of artifact storage #35

Closed hectorsector closed 4 years ago

hectorsector commented 4 years ago

This course uses artifact storage because, at the time we created it, jobs couldn't pass data to each other.

Now, we've got job outputs! Let's update the course to use these new parameters.

/cc @mattdavis0351 I'd love your help in making this happen sometime this week -- folks are going to be using this course for Satellite workshops.

mattdavis0351 commented 4 years ago

@hectorsector I disagree. Job outputs are ephemeral in nature and in this course we are storing a fully built artifact. The entire point of a CI pipeline is to result in a built and tested artifact that you can then do as you wish with. Making this artifact ephemeral goes against that widely accepted practice.

Job outputs are better suited for passing data between jobs, not long lasting artifacts. Having that fully tested build available for download is what makes artifact storage the better choice in this course.

mattdavis0351 commented 4 years ago

That being said, let's add that to the basic workflow course and get that thing primed for Universe. That way we can demonstrate this and we wouldn't just be using features for the sake of using them.

hectorsector commented 4 years ago

I haven’t had a chance to play with it enough to know whether it would make sense for this course, but I’ll defer to you.

@ppremk we’ll keep this course the way it is, see above.

That being said, let's add that to the basic workflow course and get that thing primed for Universe.

We don’t have a basic workflow course yet, and I don’t think it’s realistic to get it shipped by Satellite (next week). But we should open an issue in the content repo about it.

That way we can demonstrate this and we wouldn't just be using features for the sake of using them.

Who? Me?

ppremk commented 4 years ago

The workshop is completed. Thanks y'all for the support in here too ❤️

mattdavis0351 commented 4 years ago

Since this is not the intended use for job outputs, and this discussion seems resolved, I am closing this issue. Reopen if need be 😄