githubtraining / using-github-actions-for-ci

Course repository for "GitHub Actions: Continuous Integration"
https://lab.github.com/githubtraining/github-actions:-continuous-integration
Creative Commons Attribution 4.0 International
3 stars 16 forks source link

Node 8.x fails build, 10.x and higher work #44

Closed bjbuter closed 4 years ago

bjbuter commented 4 years ago

Bug Report

Current behavior Step 7 and later (06_custom-workflow.md) asks to use Node 8.x and 10.x, however all 8.x builds going forward fail.

Reproduction Steps to reproduce the behavior in the course:

  1. Go to Step 7: use something similar to: node-version: [8.x, 10.x] in .github/workflows/nodejs.yml
  2. Click on Actions and the 8.x build consistently fails through the rest of the course.

Expected behavior After following the course steps I expect all builds to pass before "Step 9: Use multiple jobs"

Possible solution Use Node [10.x, 12.x] or [12.x, 14.x] throughout the course