githubtraining / using-github-actions-for-ci

Course repository for "GitHub Actions: Continuous Integration"
https://lab.github.com/githubtraining/github-actions:-continuous-integration
Creative Commons Attribution 4.0 International
3 stars 16 forks source link

Add images and update node versions to 12.x and 14.x #46

Closed a-a-ron closed 4 years ago

a-a-ron commented 4 years ago

This resolves https://github.com/githubtraining/using-github-actions-for-ci/issues/17 by adding some images images to the response files.

Images
![CI](https://user-images.githubusercontent.com/6351798/88594426-66c4ef00-d01e-11ea-8ddd-a05e1850b801.png) ![fix](https://user-images.githubusercontent.com/6351798/88594428-688eb280-d01e-11ea-91f2-529303f2c4d3.png) ![workflow](https://user-images.githubusercontent.com/6351798/88594450-704e5700-d01e-11ea-9411-c921693011d9.png) ![custom-workflow-list](https://user-images.githubusercontent.com/6351798/88594454-717f8400-d01e-11ea-929a-e49cb96fd941.png)

This also fixes https://github.com/githubtraining/using-github-actions-for-ci/issues/44by updating the node versions from 8.x and 10.x to 12.x and 14.x.

@githubtraining/programs

github-learning-lab[bot] commented 4 years ago

Your draft course version was created!


You can edit it using the Course Builder UI!

hectorsector commented 4 years ago

@a-a-ron when I join the branch deployment I get blank steps, do you see the same thing or does it work for you?

Screen Shot 2020-07-27 at 6 38 58 PM
a-a-ron commented 4 years ago

when I join the branch deployment I get blank steps, do you see the same thing or does it work for you?

@hectorsector, hmmm. Yes, I'm seeing the same thing.

a-a-ron commented 4 years ago

Thanks for opening an issue for it, @hectorsector. I was just about to do that

a-a-ron commented 4 years ago

I also updated the node versions in this course to 12.x and 14.x to resolve the bug as reported in https://github.com/githubtraining/using-github-actions-for-ci/issues/44

brianamarie commented 4 years ago

I tried testing this out and:

I'm not sure why this is happening, but it is definitely not expected behavior. My next steps would be to test this course in its published version to ensure this bug is unique to this branch, but I need to move on to other tasks at the moment. I will circle back to this, in case nobody else gets to it first.

brianamarie commented 4 years ago

Going through the course on the published version:

github-learning-lab[bot] commented 4 years ago
This pull request will create a new major version of your course; changes to the title and other metadata will only apply to the course once the pull request is merged!