search

githubtraining / using-github-actions-for-ci

Course repository for "GitHub Actions: Continuous Integration"
https://lab.github.com/githubtraining/github-actions:-continuous-integration
Creative Commons Attribution 4.0 International
3 stars 16 forks source link

The `Needs` Key is Missing From Download Artifact Lab #48

Open sherl0cks opened 4 years ago

sherl0cks commented 4 years ago

Bug Report

Current behavior Without needs: build the test job will run before the build artifact is uploaded and fail.

Reproduction Just follow the comments from the bot as is.

Expected behavior The builds work.

Possible solution There is a PR suggestion for this now, but it would be helpful to have it in the copy paste example as the needs concept is not yet introduced. https://github.com/githubtraining/using-github-actions-for-ci/blob/master/responses/11_needs-suggestion.md

Additional context Great lab all in all!

brianamarie commented 3 years ago

If anyone would like to contribute, our first step is duplicating this issue.