search

githubtraining / using-github-actions-for-ci

Course repository for "GitHub Actions: Continuous Integration"
https://lab.github.com/githubtraining/github-actions:-continuous-integration
Creative Commons Attribution 4.0 International
3 stars 16 forks source link

Bug: Test results in the first step #62

Open abhilipsasahoo03 opened 2 years ago

abhilipsasahoo03 commented 2 years ago

Bug Report

Current behavior

Node 12.x build fails, 14.x and 16.x get cancelled right after that. Plus, there is no response from the github-learning-lab bot.

Screenshot_2022-02-18-07-40-47-869_com.github.android.jpg

Screenshot_2022-02-18-07-41-03-578_com.github.android.jpg

Screenshot_2022-02-18-07-41-11-736_com.github.android.jpg

Screenshot_2022-02-18-07-38-30-274_com.android.chrome.jpg

Reproduction

Steps to reproduce the behavior in the course:

  1. Created node.js workflow
  2. Used the node.js template: nodejs.yml
  3. Created pull request titled as desired by the bot
  4. Came across failed and cancelled builds
  5. Received no response from the bot

Expected behavior

Expected a response from github-learning-lab bot after the GitHub Actions finished running the workflow, in order to proceed to the next step.

Suggestions

It seems like the template workflow broke some of the assumptions as per the learning-lab bot's expectations due to which there's no response. FYI, this is similar to issue #11.

pshevche commented 2 years ago

I think the problem is in the course config here https://github.com/githubtraining/using-github-actions-for-ci/blob/main/config.yml#L74

The workflow's template has changed and the line numbers don't match the expected sections. Should be an easy fix, I could take on this issue. However, what is the current way of testing fixes to the course? It seems like you can't create new courses unless you belong to the Github team. And that is expected by https://github.com/githubtraining/community-contributors/blob/main/CONTRIBUTING.md#how-to-contribute.