search

githubtraining / write-github-script

Course repo for Learning Lab course GitHub Actions: Using GitHub Script
https://lab.github.com/githubtraining/github-actions:-using-github-script
Creative Commons Attribution 4.0 International
6 stars 8 forks source link

Consider validating against PR titles instead of numbers #7

Open hectorsector opened 4 years ago

hectorsector commented 4 years ago

When validating a learner's action, leaving everything up to the pull request number puts the learner in a state that they are unable to recover from. For example, after the learner merges say PR 2, and let's assume Learning Lab misses that event (it did in my testing), the learner is then unable to move forward because they are told to merge PR 2. Instead, we can capture the title, and tell the learner that all the need to do is merge a PR with that title.

https://github.com/githubtraining/write-github-script/blob/3396a674484501dd49d522d333af182930a6c59a/config.yml#L123-L134

mattdavis0351 commented 4 years ago

@hectorsector you ran into this issue even with the store implemented?

hectorsector commented 4 years ago

Yes! This is an issue with too strict of a validation on the PR number. The example I described above happened to me.

I guess our options are: