gitify-app / gitify

GitHub notifications on your menu bar. Available on macOS, Windows & Linux.
https://www.gitify.io
MIT License
4.39k stars 256 forks source link

feat: support multiple accounts #1201

Closed setchy closed 4 weeks ago

setchy commented 1 month ago

This PR adds support for multiple GitHub Cloud or GitHub Enterprise Service accounts. 🎉

Majority of the code changes were to:

Closes #365

setchy commented 1 month ago

I think this is ready for review and ideally further local testing.

setchy commented 4 weeks ago

looking into the test coverage drop 👀

afonsojramos commented 4 weeks ago

Locally tested and everything looks awesome! One edge case that we can improve is:

image

When using the same account twice (same PAT even), the dropdown doesn't work, although it does show.

image
setchy commented 4 weeks ago

the dropdown doesn't work, although it does show.

when you scroll, do you see the duplicate account header and notifications?
UPDATE: tested myself - it behaves as I expected (ie: showing duplicate the account details)

were you expecting it to be interactive (spoiler: i was too, but atm, it isn't)

setchy commented 4 weeks ago

One edge case that we can improve

ha - you found the edge case straight away... yep, haven't implemented any duplicate checking - figured that can just be handled by end-users :)