Closed setchy closed 4 weeks ago
I think this is ready for review and ideally further local testing.
looking into the test coverage drop 👀
Locally tested and everything looks awesome! One edge case that we can improve is:
When using the same account twice (same PAT even), the dropdown doesn't work, although it does show.
the dropdown doesn't work, although it does show.
when you scroll, do you see the duplicate account header and notifications?
UPDATE: tested myself - it behaves as I expected (ie: showing duplicate the account details)
were you expecting it to be interactive (spoiler: i was too, but atm, it isn't)
One edge case that we can improve
ha - you found the edge case straight away... yep, haven't implemented any duplicate checking - figured that can just be handled by end-users :)
This PR adds support for multiple GitHub Cloud or GitHub Enterprise Service accounts. 🎉
Majority of the code changes were to:
getAccountUUID
for notification interactions (mark as read, raise native notifications, etc) so that state is correctly managed per account and not per hostnameCloses #365