search

gitify-app / gitify

GitHub notifications on your menu bar. Available on macOS, Windows & Linux.
https://www.gitify.io
MIT License
4.39k stars 256 forks source link

build(release): remove gh_token env #1213

Closed setchy closed 4 weeks ago

setchy commented 1 month ago

~use default auto provisioned GitHub actions token instead of my custom PAT~

remove gh_token env variable. should use github_token

setchy commented 4 weeks ago

The default default GitHub actions token, afaik doesn't need to be provided at all, so we can just delete it I think!

even better. i was trying to recall when this got added. i think it was during our notorization dark days haha

setchy commented 4 weeks ago

looking again, i think it's needed so that it's passed as process.env. to electron builder

setchy commented 4 weeks ago

i take it back :p https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow

let's give it a shot. worst case we add it back in when we do v5.8.0 release :)

removed in new commit

setchy commented 3 weeks ago

no dice - had to revert this for the 5.8.0 release...

without specifying GITHUB_TOKEN or GH_TOKEN, electron-builder doesn't work.

using the default GITHUB_TOKEN doesn't have enough permissions to upload artifacts to the release notes.

Will continue using my GH_TOKEN for now. Ideally we'd create this within the gitify-app org