gitify-app / gitify

GitHub notifications on your menu bar. Available on macOS, Windows & Linux.
https://www.gitify.io
MIT License
4.39k stars 256 forks source link

refactor: biome linter updates #1226

Closed setchy closed 3 weeks ago

setchy commented 3 weeks ago

A selection of updates to remove biome warnings, including:

setchy commented 3 weeks ago

@afonsojramos - appreciate your feedback on this too when you get a chance 🙏

afonsojramos commented 3 weeks ago

According to React docs:

dependencies: The list of all reactive values referenced inside of the fn code. Reactive values include props, state, and all the variables and functions declared directly inside your component body. If your linter is configured for React, it will verify that every reactive value is correctly specified as a dependency. The list of dependencies must have a constant number of items and be written inline like [dep1, dep2, dep3]. React will compare each dependency with its previous value using the Object.is comparison algorithm.

https://react.dev/reference/react/useCallback

Seems to me that passing these functions as dependencies won't have any impact tbh...