search

gitify-app / gitify

GitHub notifications on your menu bar. Available on macOS, Windows & Linux.
https://www.gitify.io
MIT License
4.38k stars 256 forks source link

build: move lint into separate workflow #1246

Closed setchy closed 2 weeks ago

setchy commented 2 weeks ago

Hmmm, why exactly?

Explicit check feedback

afonsojramos commented 2 weeks ago

Hmmm, why exactly?

Explicit check feedback

Isn't looking at the workflow failure reason not enough? 😅

setchy commented 2 weeks ago

Hmmm, why exactly?

Explicit check feedback

Isn't looking at the workflow failure reason not enough? 😅

I think it's more intuitive if it is a separate step, whether that's a separate workflow file (lint.yml) or the same (test.yml).

We have this clarity already in Build App and Release App and Validators 😎

bmulholland commented 2 weeks ago

IMHO this is best practice :)