search

gitify-app / gitify

GitHub notifications on your menu bar. Available on macOS, Windows & Linux.
https://www.gitify.io
MIT License
4.38k stars 256 forks source link

style: toggle on row click & action buttons order #1248

Closed afonsojramos closed 2 weeks ago

afonsojramos commented 2 weeks ago

Adds the functionality that was referred to in https://github.com/gitify-app/gitify/pull/1245#issuecomment-2171428582

Also sorted the order of the buttons to try to attain some added consistency.

image
afonsojramos commented 2 weeks ago

@setchy what do you think of this one?

setchy commented 2 weeks ago

@setchy what do you think of this one?

clever ordering hack. does mean we diverge a bit from GitHub UI, but worth it imo

afonsojramos commented 2 weeks ago

How so? Because here the disable notification is right next to the check? Don't think that's deviating too much tbh

image
setchy commented 2 weeks ago

How so? Because here the disable notification is right next to the check? Don't think that's deviating too much tbh

image

Just recalling a previous PR discussion on these actions buttons.

I'm good with it