Closed Araxeus closed 3 months ago
thanks @Araxeus 👏 would you mind adding a screenshot for light and dark mode 🙏
Colors could be lighter, and im not sure if raw css is your preferred way of dealing with this, thoughts?
What do you think about adding it into index.html
directly?
![image](https://github.com/gitify-app/gitify/assets/78568641/11656de6-5a0d-4a12-b97c-37cd83d96708) ![image](https://github.com/gitify-app/gitify/assets/78568641/b96adb21-f572-4100-9c7e-877d1e11743d) ![image](https://github.com/gitify-app/gitify/assets/78568641/daf8254e-81ec-48fa-9003-7a92e2347940)
![image](https://github.com/gitify-app/gitify/assets/78568641/2eef5581-1f75-4b71-8ea7-8fcc4332418e) ![image](https://github.com/gitify-app/gitify/assets/78568641/5cab561f-1c7e-4c30-be43-5090dd8829c0) ![image](https://github.com/gitify-app/gitify/assets/78568641/6337285a-944c-48b8-a7bd-9759985764b0)
Looks really nice!
Do you think it's worth making the light
theme match the custom scrollbar (with suitable colors)?
Do you think it's worth making the
light
theme match the custom scrollbar (with suitable colors)?
![image](https://github.com/gitify-app/gitify/assets/78568641/0c08f646-811f-4529-9a8f-ee721fdc09e1) ![image](https://github.com/gitify-app/gitify/assets/78568641/f7c977a2-9628-459d-8d6b-3ca20d5639d9) ![image](https://github.com/gitify-app/gitify/assets/78568641/34f3b2b1-d300-4dac-9f49-982796a6c756)
overall i'd say it looks better than the native one? should i commit this?
Well I can't even commit, it looks like its because the change is only affecting an html file, and biome throw an error because it has nothing to check?
Well I can't even commit, it looks like its because the change is only affecting an html file, and biome throw an error because it has nothing to check?
just pushed a fix to our lint-staged
config. can you try again now please
note: html::-webkit-scrollbar
is used because a top level ::-webkit-scrollbar
would override the html.dark::-webkit-scrollbar
style even with !important
which is a bit sad because it makes the css longer but I don't see a better way to do it
sorry for the double force pushes but i made a typo twice in the commit description 🤦♂️
Just sharing an observation... scrollbars are now permanently visible on macOS when there is overflow content.
Previously they would hide/show based on scrolling activity.
Closes #1244
Colors could be lighter, and im not sure if raw css is your preferred way of dealing with this, thoughts?