feat: notification filters

gitify-app / gitify

GitHub notifications on your menu bar. Available on macOS, Windows & Linux.

https://www.gitify.io

MIT License

4.38k stars 256 forks source link

feat: notification filters #1304

Closed setchy closed 18 hours ago

setchy commented 1 week ago

New Filter sidebar route which contains any post filtering controls, including

show bot notifications - moved from Settings
reason filtering - new. closes #264

When any non-default filters are selected, it will show a visual indicator

bmulholland commented 1 week ago

I guess the settings store doesn't support storing arrays?

setchy commented 1 week ago

I guess the settings store doesn't support storing arrays?

it can with a bit of work 😅. give me a few minutes to tinker with that

setchy commented 1 week ago

I guess the settings store doesn't support storing arrays?

updated to use an array Reason[] instead of a nasty string 🙈

setchy commented 1 week ago

Thanks! I think the extra work to make it an array was worth it :)

100000%

setchy commented 1 week ago

@afonsojramos - looking forward to your feedback on this, too, before I merge

setchy commented 5 days ago

small update... changed the reset to default filters to match other footer styling

bmulholland commented 2 days ago

FWIW, in that last screenshot, there's no explanation text... I was looking for it and it still look me a minute to find the icon. Without the context, I'd never have guessed that's what the button does!

setchy commented 2 days ago

Even with the hover text? 🤔

afonsojramos commented 1 day ago

What about adding a counter to the filter icon on the sidebar that when hovered showed a tooltip with the filters being used which could be individually removed AND cleared?

setchy commented 1 day ago

Updated to use Clear filters