gitify-app / gitify

GitHub notifications on your menu bar. Available on macOS, Windows & Linux.
https://www.gitify.io
MIT License
4.38k stars 256 forks source link

refactor: split settings into smaller components #1320

Closed setchy closed 2 days ago

setchy commented 5 days ago

Split our growing Settings component into smaller, more focused components.

setchy commented 2 days ago

I do wonder if these per-component test files are more effort than they're worth. Integration-level tests could cover all of these, pretty much, without needing to have a test-per. As it is, I feel that the tests make the system harder to change without contributing much resiliency to errors.

I would argue the opposite. They're easy to write and easy to make changes. I haven't had any concerns

bmulholland commented 2 days ago

Oh cool, good news!

afonsojramos commented 2 days ago

It would have been way easier to merge this after #1318 :(

afonsojramos commented 2 days ago

Nevermind, it was rather easy afterall 😁