search

gitify-app / gitify

GitHub notifications on your menu bar. Available on macOS, Windows & Linux.
https://gitify.io
MIT License
4.49k stars 257 forks source link

feat(sidebar): highlight selected route #1330

Closed setchy closed 1 month ago

setchy commented 3 months ago

Highlight sidebar button when route being shown

bmulholland commented 2 months ago

I expected to love it, but found the video confusing. I think it's because only two icons change color? Also, something about the red throws me off, like it's an error state.

That could just be because I'm not the one controlling it, though. So may or may not be valid feedback :)

setchy commented 2 months ago

I expected to love it, but found the video confusing. I think it's because only two icons change color? Also, something about the red throws me off, like it's an error state.

That could just be because I'm not the one controlling it, though. So may or may not be valid feedback :)

It's meant to be orange, but agree it does come across differently. Is there a different color you think would work well?

afonsojramos commented 2 months ago

Maybe no color, but a little triangle next to it? Let me draw something up!

afonsojramos commented 2 months ago

Like this? image

Otherwise, I'd just stick with the color on hover.

setchy commented 2 months ago

Or using a dot (ignore formatting/alignment for now) with matching icon color

Screenshot 2024-07-08 at 11 10 32 AM Screenshot 2024-07-08 at 11 10 37 AM
afonsojramos commented 2 months ago
image

This is too packed. And shifting the icon's position feels weird UX too. I say let's go with the hover's opacity, simpler implementation and cleaner UI

bmulholland commented 2 months ago

Yeah I agree that moving the icon would be weird.

setchy commented 2 months ago

agree, didn't intend for the icons to move around in the final version, hence the (ignore formatting/alignment for now) comment (it was a quick/dirty prototype).

Nonetheless, will look to update the hover opacity instead

setchy commented 2 months ago

Me again 😅

How about a simple tailwind ring @afonsojramos @bmulholland ?

Screenshot 2024-07-09 at 9 24 27 AM Screenshot 2024-07-09 at 9 24 34 AM

I played around with different opacity combinations but found it not very useful.

bmulholland commented 2 months ago

I like the ring. Personal opinion though.

setchy commented 2 months ago

Updated to use a shadow. imho, this is the best of the options explored above.

https://github.com/user-attachments/assets/a443b79d-30e6-42b5-94a5-e6862a95ce8b

setchy commented 2 months ago

Moving back to draft as @afonsojramos is looking into some things on his side

setchy commented 1 month ago

Closing this concept for now