search

gitify-app / gitify

GitHub notifications on your menu bar. Available on macOS, Windows & Linux.
https://www.gitify.io
MIT License
4.39k stars 256 forks source link

Hide notifications from bot accounts not working on native notifications #1331

Closed Araxeus closed 4 days ago

Araxeus commented 5 days ago

I still get native notifications about PR's made by depandabot, when i open gitify they are not shown

Gitify Version

5.9.0

Operating System

Windows

GitHub Account

GitHub Cloud

NOTES:

seems to happen because notifications arent filtered before being triggered natively

https://github.com/gitify-app/gitify/blob/b7157332f64a23c8d6a9447779c055213b37e08b/src/hooks/useNotifications.ts#L65-L81

setchy commented 4 days ago

https://github.com/gitify-app/gitify/blob/main/src%2Futils%2Fnotifications.ts#L123-L151

It should be filtering them 🤔

Araxeus commented 4 days ago

image

I don't know how it happened then 🤨

setchy commented 4 days ago

I haven't been able to recreate this (see recording below).

https://github.com/gitify-app/gitify/assets/386277/ba19dae4-3427-4a62-af30-7ec274dcfa6e

Note: once a native notification has been raised, we do not manage their state (clear, filter, etc).

For now I'll be closing this issue. If you are able to reproduce it we can reopen this and triage further.

Araxeus commented 4 days ago

Yeah I tried reproducing but I haven't been able either... Its so weird because i did get this notification this morning.

ill throw it off as a cosmic ray 🤷‍♂️