gitify-app / gitify

GitHub notifications on your menu bar. Available on macOS, Windows & Linux.
https://www.gitify.io
MIT License
4.39k stars 256 forks source link

feat: zoom buttons #1333

Closed afonsojramos closed 20 hours ago

afonsojramos commented 4 days ago

This is the second iteration of the zoom feature after #1318.

Closes #1312.

Dark Light
image image

Had to add a timeout to the listening to the resize event because it was very trigger-happy. Found a fix by doing debounced update calls. More info here

@adufr @setchy Let me know your thoughts.

setchy commented 4 days ago

@afonsojramos - nice pivot. Seems much more user-friendly and predictable.

minor nit: could it be a little smaller (vertically). Otherwise, lgtm!

afonsojramos commented 1 day ago

@setchy updated the image now. Looking way sleeker now!

setchy commented 1 day ago

@setchy updated the image now. Looking way sleeker now!

Our zoom controls went on a diet! Nice!

setchy commented 1 day ago

I'm unable to run this branch locally. Getting the following error in DevConsole 🤔

Screenshot 2024-07-08 at 10 42 05 AM

I've tried multiple times a pnpm clean && pnpm i && pnpm watch but no dice.

Other branches are ok...

afonsojramos commented 1 day ago

I'm unable to run this branch locally. Getting the following error in DevConsole 🤔 Screenshot 2024-07-08 at 10 42 05 AM

I've tried multiple times a pnpm clean && pnpm i && pnpm watch but no dice.

Other branches are ok...

Just ran on main and I am also getting that error 🤔

setchy commented 1 day ago

Error no longer in the console, but still loading as a blank screen for me 🤷‍♂️

Screenshot 2024-07-08 at 1 22 01 PM
setchy commented 22 hours ago

I haven't been able to re-launch the app with a saved zoomPercentage. Is this working on your end @afonsojramos?

steps to reproduce:

setchy commented 21 hours ago

I haven't been able to re-launch the app with a saved zoomPercentage. Is this working on your end @afonsojramos?

steps to reproduce:

* set my zoom level to 80%

* confirmed that local storage has `zoomPercentage: 80` persisted

* restarted the app

* app loads at 100%, shows in the Settings view as 100%

* local storage still shows `zoomPercentage: 80`

pushed a small update to load the existing settings.