search

gitify-app / gitify

GitHub notifications on your menu bar. Available on macOS, Windows & Linux.
https://gitify.io
MIT License
4.55k stars 258 forks source link

Feature request: show notifications count next to icon in menubar #750

Closed adufr closed 7 months ago

adufr commented 9 months ago

📝 Provide a description of the new feature

It would be nice to show the notifications count next to the Gitify icon in the menubar

From what I saw it's an image, so it should be possible to dynamically generate one by using some 3rd party library. EDIT: Use the menubarApp.tray.setTitle() API

For example with the "Reminders MenuBar" icon:

image image

➕ Additional Information

I'd like to work in this if you approve the feature request! 😉

bmulholland commented 9 months ago

This is probably down to personal preference and workflow. For me, I like the simplicity. See also https://github.com/gitify-app/gitify/issues/728

adufr commented 9 months ago

This is probably down to personal preference and workflow. For me, I like the simplicity. See also #728

I agree, some people might not want this feature, but IMO it's sad to prevent other people from benefiting from it; so a setting could be the solution (+ the setting would be a simple checkbox so it wouldn't bring much complexity)

I read #728 and gave my opinion there!

setchy commented 9 months ago

I think this would be fine so long as the feature is behind a settings flag. Personally, I like the simplicity of the different colored icon.

adufr commented 9 months ago

Thank you both for your input 😄 I'll start working on adding this setting as soon as I have some time!

adufr commented 8 months ago

Note: this feature is much easier to implement than I anticipated, I don't have to do any on-the-fly image manipulation as the menubarApp.tray.setTitle() API serves my purpose 😛

PR is coming!

setchy commented 7 months ago

This feature was released today in v5.2.0