gitkraken / gk-cli

GitKraken CLI Releases and Documentation
https://www.gitkraken.com
Other
122 stars 48 forks source link

Not opening correct repo from graph command #5

Open thenexxuz opened 1 year ago

thenexxuz commented 1 year ago

Describe the bug Not opening correct repo from graph command

To Reproduce Steps to reproduce the behavior:

  1. Open a repo in GitKraken Client
  2. Close GitKtaken Client
  3. from command line run gk graph from a different repo
  4. GitKraken opens but the repo you are in is not opened

Expected behavior GitKraken Client opens the repo you ran the command in.

Screencast from 2023-05-25 17-23-24.webm

sergiolms commented 1 year ago

Hey @thenexxuz, thanks for reporting this issue. It should be fixed by upgrading GitKraken Client to 9.6.0.

thenexxuz commented 1 year ago

I'll check it out once in the office, thank you!

thenexxuz commented 1 year ago

I have GitKraken v9.6.0 and gk-cli v1.0.7 and the issue is still there Screencast from 2023-07-18 09-12-04.webm

thenexxuz commented 1 year ago

I am on an Arch Linux based distro, EndeavourOS. Not sure if it is happening on other distros/OSs.

zawata commented 1 year ago

Hi. I put the fix in GK for this issue(or at least I thought I did). I'm actually running Manjaro so I don't think arch-linux is the issue.

I'm not able to repro this issue since "fixing" it in 9.6.0 so I'd like some help troubleshooting this if possible.

Thanks!

Also @sergiolms can you reopen the issue if this is still occurring?

thenexxuz commented 10 months ago

Sorry for the late response.

This is the result of the command

[nexxuz@firefly fake-xost-gen]$ strace -f -e trace=execve -s 256 2>&1 gk graph | grep "gitkraken://"
[pid 1532204] execve("/usr/bin/xdg-open", ["xdg-open", "gitkraken://repo/%2Fhome%2Fnexxuz%2FDevelopment%2FDevNull%2Ffake-xost-gen"], 0xc0001efa40 /* 55 vars */) = 0
[pid 1532206] execve("/usr/bin/gio", ["gio", "open", "gitkraken://repo/%2Fhome%2Fnexxuz%2FDevelopment%2FDevNull%2Ffake-xost-gen"], 0x55bdaaf8c4a0 /* 55 vars */) = 0
zawata commented 7 months ago

Took a another swing at diagnosing this, nothing sticks out from the URIs presented in the strace command. It decodes to the path /home/nexxuz/Development/DevNull/fake-xost-gen.

We've done a couple refactors and bug-fixes to deeplink processing in the last few months, if this repro's in 9.11.1, We can take more drastic actions.